Page MenuHomePhabricator
Differential D5793

Fix @generated marking in Phab for generate-seeds.py
ClosedPublic
Actions

Authored by jasonbcox on Apr 21 2020, 01:33.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1bccab0c3e44: Fix @generated marking in Phab for generate-seeds.py
rABC1bccab0c3e44: Fix @generated marking in Phab for generate-seeds.py
Summary

This ensures Phabricator doesn't see the file as automatically generated.

Test Plan
python3 generate-seeds.py . > ../../src/chainparamsseeds.h

No differences should be generated.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gen-seeds-generated
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10328
Build 18477: Default Diff Build & Tests
Build 18476: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 21 2020, 01:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 21 2020, 01:33
teamcity added a comment.Apr 21 2020, 01:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

jasonbcox added inline comments.Apr 21 2020, 01:33
contrib/seeds/generate-seeds.py
80

Linter made me do it.

jasonbcox mentioned this in D5790: core -> ABC in extract_strings_qt.py.Apr 21 2020, 01:34
teamcity added a comment.Apr 21 2020, 01:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10328: Diff 18990.Apr 21 2020, 01:56
Fabien accepted this revision.Apr 21 2020, 07:48
This revision is now accepted and ready to land.Apr 21 2020, 07:48
deadalnix accepted this revision.Apr 21 2020, 14:13
Closed by commit rABC1bccab0c3e44: Fix @generated marking in Phab for generate-seeds.py (authored by jasonbcox). · Explain WhyApr 21 2020, 16:28
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1bccab0c3e44: Fix @generated marking in Phab for generate-seeds.py.
jasonbcox added a commit: rSTAGING1bccab0c3e44: Fix @generated marking in Phab for generate-seeds.py.May 5 2020, 19:04

Revision Contents
Changeset List

PathSize
contrib/
seeds/
4 lines

Diff 18990

View Options

contrib/seeds/generate-seeds.py

Loading...