Page MenuHomePhabricator

Only log "Using PATH_TO_bitcoin.conf" message on startup if conf file exists.
ClosedPublic

Authored by deadalnix on Apr 22 2020, 21:49.

Details

Summary

Currently we log a message indicating that a bitcoin.conf file is being used
even if one does not exists. This commit changes the logic to only display
this message if a config file exists and logs a separate message
if no config file exists. Additionally, a warning is now logged if the file
path passed in the -conf flag does not exist.

This is a backport of Core PR14057

Test Plan

Run bitcoind and check the output for

Config file: /home/deadalnix/.bitcoin/bitcoin.conf (not found, skipping)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14057
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10360
Build 18541: Default Diff Build & Tests
Build 18540: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Apr 22 2020, 21:52
nakihito requested changes to this revision.Apr 22 2020, 21:54

QT test plan?

This revision now requires changes to proceed.Apr 22 2020, 21:54

This does not touch Qt.

This revision is now accepted and ready to land.Apr 22 2020, 22:29