Have the seeder database track and relay additional information
AbandonedPublic
Actions

Authored by nakihito on Apr 24 2020, 23:03.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

There is some information that the seeder does not currently record that
would be useful in determining which nodes are good, bad, or should be
banned. This patch has the seeder start recording and passing that
information along.

Test Plan

ninja
ninja check-bitcoin-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Branch

SeederDBTracksMoreInfo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10391
Build 18603: Default Diff Build & Tests
Build 18602: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 24 2020, 23:03

Owners added a reviewer: Restricted Owners Package.Apr 24 2020, 23:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2020, 23:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito added a child revision: D5834: Pass more informaion from the seeder DB to CSeederNode.Apr 24 2020, 23:21

The title and summary are incredibly vague. Why is this information useful? What is the goal here?

This revision now requires changes to proceed.Apr 24 2020, 23:23

jasonbcox mentioned this in D5834: Pass more informaion from the seeder DB to CSeederNode.Apr 24 2020, 23:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10391: Diff 19103.Apr 24 2020, 23:29

No need to break this up.

Revision Contents
Changeset List

Path

Size

src/

seeder/

db.h

19 lines

db.cpp

4 lines

Diff 19103

View Options

src/seeder/db.h