Page MenuHomePhabricator
Differential D5850

Reduce the use of ClearArg and only guarantee that we clear forced args.
ClosedPublic
Actions

Authored by deadalnix on Apr 27 2020, 00:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb60a395a83ae: Reduce the use of ClearArg and only guarantee that we clear forced args.
rABCb60a395a83ae: Reduce the use of ClearArg and only guarantee that we clear forced args.
Summary

This feature doesn't exist in Core, so reducing its surface make sense. It is not strictly limited to forced args at the moment, but the name provide intent and we'll get there after backporting Core PR15934 .

Test Plan
make check

Updated test to reflect the new behavior.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clearforcedarg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10420
Build 18661: Default Diff Build & Tests
Build 18660: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 27 2020, 00:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2020, 00:58
teamcity edited the summary of this revision. (Show Details)Apr 27 2020, 00:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Apr 27 2020, 00:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 27 2020, 01:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10420: Diff 19141.Apr 27 2020, 01:11
Fabien accepted this revision.Apr 27 2020, 08:51
This revision is now accepted and ready to land.Apr 27 2020, 08:51
Closed by commit rABCb60a395a83ae: Reduce the use of ClearArg and only guarantee that we clear forced args. (authored by deadalnix). · Explain WhyApr 27 2020, 12:28
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb60a395a83ae: Reduce the use of ClearArg and only guarantee that we clear forced args..
deadalnix added a commit: rSTAGINGb60a395a83ae: Reduce the use of ClearArg and only guarantee that we clear forced args..May 5 2020, 19:08

Revision Contents
Changeset List

PathSize
src/
test/
2 lines
2 lines
29 lines
util/
6 lines
3 lines

Diff 19141

View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...