Page MenuHomePhabricator

Fix seeder compilation warnings
ClosedPublic

Authored by kyuupichan on Oct 5 2017, 14:01.

Details

Summary

Several of these on MacOSX at least

CXX seeder/libbitcoin_seeder_a-protocol.o
In file included from seeder/protocol.cpp:8:
./seeder/util.h:51:23: warning: passing an object of reference type to 'va_start' has undefined behavior [-Wvarargs]

va_start(arg_ptr, format);
                  ^

Everywhere actually passes a C string not a std::string so it seemed simplest to just switch to that.

Test Plan

make check; run binary

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 947
Build 947: arc lint + arc unit

Event Timeline

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptOct 5 2017, 14:01
This revision is now accepted and ready to land.Oct 5 2017, 15:09
This revision was automatically updated to reflect the committed changes.