Page MenuHomePhabricator
Differential D5864

Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 27 2020, 22:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGc006172f5b02: Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan
rABCc006172f5b02: Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rawtxn2.diff

Verify changes in rawtxn2.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

rawtxn2.diff:

rawtxn2.diff1 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-rawtxn2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10455
Build 18730: Default Diff Build & Tests
Build 18729: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 27 2020, 22:47
Owners added a reviewer: Restricted Owners Package.Apr 27 2020, 22:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 27 2020, 22:47
nakihito planned changes to this revision.Apr 27 2020, 22:47
teamcity edited the summary of this revision. (Show Details)Apr 27 2020, 22:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Apr 27 2020, 22:50
nakihito edited the summary of this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Apr 27 2020, 22:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 27 2020, 23:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10441: Diff 19184.Apr 27 2020, 23:13
Fabien requested changes to this revision.Apr 28 2020, 20:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
1213 ↗(On Diff #19184)

Fix layout

1346 ↗(On Diff #19184)

Dito

1511 ↗(On Diff #19184)

Dito

1815 ↗(On Diff #19184)

Dito

This revision now requires changes to proceed.Apr 28 2020, 20:34
nakihito updated this revision to Diff 19212.Apr 28 2020, 21:22

Fixed layout.

teamcity added a comment.Apr 28 2020, 21:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Apr 28 2020, 21:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10455: Diff 19212.Apr 28 2020, 21:40
Fabien accepted this revision.Apr 29 2020, 07:08
This revision is now accepted and ready to land.Apr 29 2020, 07:08
Closed by commit rABCc006172f5b02: Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 29 2020, 17:36
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCc006172f5b02: Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGINGc006172f5b02: Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan.May 5 2020, 19:12

Revision Contents
Changeset List

PathSize
src/
rpc/
868 lines

Diff 19212

View Options

src/rpc/rawtransaction.cpp

Loading...