Page MenuHomePhabricator

Finish Passing rpc/rawtransaction RPC results and examples to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 27 2020, 22:47.

Details

Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rawtxn2.diff

Verify changes in rawtxn2.diff.

Scripts:


rawtxn2.diff:

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-rawtxn2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10455
Build 18730: Default Diff Build & Tests
Build 18729: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 27 2020, 22:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)
nakihito edited the test plan for this revision. (Show Details)
Fabien requested changes to this revision.Apr 28 2020, 20:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/rpc/rawtransaction.cpp
1213 ↗(On Diff #19184)

Fix layout

1346 ↗(On Diff #19184)

Dito

1511 ↗(On Diff #19184)

Dito

1815 ↗(On Diff #19184)

Dito

This revision now requires changes to proceed.Apr 28 2020, 20:34
This revision is now accepted and ready to land.Apr 29 2020, 07:08