Page MenuHomePhabricator

Pass wallet/rpcdump RPC results and examples to RPCHelpMan
ClosedPublic

Authored by nakihito on Apr 28 2020, 20:25.

Details

Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcdump.diff

Verify changes in rpcdump.diff.

Scripts:


rpcdump.diff:

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 28 2020, 20:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/rpcdump.cpp
137 ↗(On Diff #19209)

This formatting looks odd. Did the linter do this?

This revision is now accepted and ready to land.Apr 28 2020, 22:35
src/wallet/rpcdump.cpp
137 ↗(On Diff #19209)

Yeah, unfortunately, the linter forces this.