Page MenuHomePhabricator
Differential D5874

Pass wallet/rpcdump RPC results and examples to RPCHelpMan
ClosedPublic
Actions

Authored by nakihito on Apr 28 2020, 20:25.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGf2d4686b9352: Pass wallet/rpcdump RPC results and examples to RPCHelpMan
rABCf2d4686b9352: Pass wallet/rpcdump RPC results and examples to RPCHelpMan
Summary

Partial backport of Core PR14987

Test Plan

On master:

ninja
./bitcoind
./bitcoin-cli help > RPCs
./getrpchelps.sh RPCs master

Then on the patched branch:

ninja
./bitcoind
./getrpchelps.sh RPCs patched
./checkrpc.sh RPCs master patched rpcdump.diff

Verify changes in rpcdump.diff.

Scripts:

getrpchelps.sh231 BDownload

checkrpc.sh489 BDownload

rpcdump.diff:

rpcdump.diff5 KBDownload

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14987-rpcdump
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10453
Build 18726: Default Diff Build & Tests
Build 18725: arc lint + arc unit

Event Timeline

nakihito created this revision.Apr 28 2020, 20:25
Owners added a reviewer: Restricted Owners Package.Apr 28 2020, 20:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2020, 20:25
nakihito planned changes to this revision.Apr 28 2020, 20:25
teamcity edited the summary of this revision. (Show Details)Apr 28 2020, 20:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the test plan for this revision. (Show Details)Apr 28 2020, 20:28
teamcity added a comment.Apr 28 2020, 20:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito requested review of this revision.Apr 28 2020, 20:30
teamcity added a comment.Apr 28 2020, 20:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10453: Diff 19209.Apr 28 2020, 20:39
jasonbcox accepted this revision.Apr 28 2020, 22:35
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/rpcdump.cpp
137

This formatting looks odd. Did the linter do this?

This revision is now accepted and ready to land.Apr 28 2020, 22:35
nakihito added inline comments.Apr 28 2020, 22:52
src/wallet/rpcdump.cpp
137

Yeah, unfortunately, the linter forces this.

Closed by commit rABCf2d4686b9352: Pass wallet/rpcdump RPC results and examples to RPCHelpMan (authored by nakihito). · Explain WhyApr 28 2020, 22:56
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCf2d4686b9352: Pass wallet/rpcdump RPC results and examples to RPCHelpMan.
nakihito added a commit: rSTAGINGf2d4686b9352: Pass wallet/rpcdump RPC results and examples to RPCHelpMan.May 5 2020, 19:12

Revision Contents
Changeset List

PathSize
src/
wallet/
633 lines

Diff 19209

View Options

src/wallet/rpcdump.cpp

Loading...