Paths

Table of Contentst

Differential D5933

Remove hdmasterkeyid
ClosedPublic
Actions

Authored by nakihito on May 1 2020, 22:53.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC63a0aeceba57: Remove hdmasterkeyid

Summary

Deprecated return results that were scheduled to be removed in v0.21

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/345bff6013e0d1a7eb0a08a071723b27f0460b77

Test Plan

ninja
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.May 1 2020, 22:53

Owners added a reviewer: Restricted Owners Package.May 1 2020, 22:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2020, 22:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10549: Diff 19361.May 1 2020, 23:05

This is part of a larger changeset that provide an alternative. Removing the feature without providing the alternative is not acceptable.

This revision now requires changes to proceed.May 2 2020, 13:00

The removed return values are duplicates of hdseedid. It even says in the help text that its an alias for hdseedid. The rest of the PR does not actually replace this value with an alternative because the alternative is already there. See relevant changes:
src/wallet/rpcwallet.cpp
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL2421
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL2459
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL3663
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.cpp#diff-df7d84ff2f53fcb2a0dc15a3a51e55ceL3726-L3729

test/functional/wallet_hd.py
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.py#diff-9ef61f3ae1a87f72e3ea5cfd6a004110

test/functional/wallet_keypool.py
https://github.com/bitcoin/bitcoin/pull/14021/files?file-filters%5B%5D=.py#diff-26ea1fc80244e6643b72ffef4bd419a9

The PR will have to be backported eventually, and having parts of it in will just make things more confusing for everybody involved. Please backport the whole PR.

And add release notes when you change the API.

This revision now requires changes to proceed.May 9 2020, 19:33

Rebased and added release notes.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

nakihito planned changes to this revision.May 21 2020, 19:47

Harbormaster completed remote builds in B10952: Diff 20482.May 21 2020, 19:50

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

nakihito added a child revision: D6215: Test importing descriptors with key origin information and add release notes.May 21 2020, 22:58

nakihito requested review of this revision.May 21 2020, 22:58

nakihito removed a child revision: D6215: Test importing descriptors with key origin information and add release notes.May 22 2020, 19:54

deadalnix accepted this revision.May 22 2020, 21:21

This revision is now accepted and ready to land.May 22 2020, 21:21

Closed by commit rABC63a0aeceba57: Remove hdmasterkeyid (authored by nakihito). · Explain WhyMay 22 2020, 22:58

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC63a0aeceba57: Remove hdmasterkeyid.

Revision Contents
Changeset List

Path

Size

doc/

release-notes.md

2 lines

src/

wallet/

8 lines

test/

functional/

4 lines

wallet_keypool.py

3 lines

Diff 20554

doc/release-notes.md

Loading...

src/wallet/rpcwallet.cpp

Loading...

test/functional/wallet_hd.py

Loading...

test/functional/wallet_keypool.py

Loading...