Page MenuHomePhabricator

Remove hdmasterkeyid
ClosedPublic

Authored by nakihito on Fri, May 1, 22:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC63a0aeceba57: Remove hdmasterkeyid
Summary

Deprecated return results that were scheduled to be removed in v0.21

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/345bff6013e0d1a7eb0a08a071723b27f0460b77

Test Plan
ninja
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, May 1, 22:53
Owners added a reviewer: Restricted Owners Package.Fri, May 1, 22:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, May 1, 22:53
teamcity edited the summary of this revision. (Show Details)Fri, May 1, 22:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Sat, May 2, 13:00
deadalnix added a subscriber: deadalnix.

This is part of a larger changeset that provide an alternative. Removing the feature without providing the alternative is not acceptable.

This revision now requires changes to proceed.Sat, May 2, 13:00
deadalnix requested changes to this revision.Sat, May 9, 19:33

The PR will have to be backported eventually, and having parts of it in will just make things more confusing for everybody involved. Please backport the whole PR.

And add release notes when you change the API.

This revision now requires changes to proceed.Sat, May 9, 19:33
nakihito updated this revision to Diff 20482.Thu, May 21, 19:37

Rebased and added release notes.

nakihito planned changes to this revision.Thu, May 21, 19:47
nakihito requested review of this revision.Thu, May 21, 22:58
deadalnix accepted this revision.Fri, May 22, 21:21
This revision is now accepted and ready to land.Fri, May 22, 21:21
This revision was automatically updated to reflect the committed changes.