Page MenuHomePhabricator
Differential D6215

Test importing descriptors with key origin information and add release notes
ClosedPublic
Actions

Authored by nakihito on May 21 2020, 22:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC54e7526f0bfe: Test importing descriptors with key origin information and add release notes
Summary

Test is separated from the rest of the changes to make review easier.

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/4c75a69f36a7630342e68b12999115e6b6b1e1e0
https://github.com/bitcoin/bitcoin/pull/14021/commits/cb3511b9d5f3d8a86e090ebed5a4aeaf758430b8

Depends on D6230

Test Plan
ninja
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.May 21 2020, 22:58
Owners added a reviewer: Restricted Owners Package.May 21 2020, 22:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 22:58
nakihito requested review of this revision.May 21 2020, 22:58
teamcity edited the summary of this revision. (Show Details)May 21 2020, 22:58

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 21 2020, 23:00

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 23:01

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 23:02

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 23:03

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 23:07

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 23:14

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10964: Diff 20499.May 21 2020, 23:14
nakihito planned changes to this revision.May 22 2020, 19:02
nakihito updated this revision to Diff 20542.May 22 2020, 19:51

Split into smaller parts.

nakihito planned changes to this revision.May 22 2020, 19:51
teamcity added a comment.May 22 2020, 19:51

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 19:51

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 19:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

nakihito requested review of this revision.May 22 2020, 19:53
nakihito retitled this revision from Store key origin info in key metadata and import KeyOriginData when importing descriptors to Test importing descriptors with key origin information and add release notes.
nakihito edited the summary of this revision. (Show Details)
nakihito added a parent revision: D6230: Import KeyOriginData when importing descriptors.
teamcity added a comment.May 22 2020, 19:53

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

nakihito removed parent revisions: D5933: Remove hdmasterkeyid, D6004: Refactor keymetadata writing to a separate method, D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.May 22 2020, 19:54
teamcity added a comment.May 22 2020, 19:55

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 20:01

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10990: Diff 20542.May 22 2020, 20:01
deadalnix accepted this revision.May 22 2020, 21:38
This revision is now accepted and ready to land.May 22 2020, 21:38
Closed by commit rABC54e7526f0bfe: Test importing descriptors with key origin information and add release notes (authored by Andrew Chow <achow101-github@achow101.com>, committed by nakihito). · Explain WhyMay 22 2020, 23:48
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC54e7526f0bfe: Test importing descriptors with key origin information and add release notes.

Revision Contents
Changeset List

PathSize
doc/
14 lines
test/
functional/
66 lines

Diff 20564

View Options

doc/release-notes.md

Loading...
View Options

test/functional/wallet_importmulti.py

Loading...