Page MenuHomePhabricator

Store key origin info in key metadata
ClosedPublic

Authored by nakihito on Fri, May 22, 19:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCc4f1a7bf5d73: Store key origin info in key metadata
Summary

Store the master key fingerprint and derivation path in the
key metadata. hdKeypath is kept to indicate the seed and for
backwards compatibility, but all key derivation path output
uses the key origin info instead of hdKeypath.

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/eab63bc264a35cf21738e8535773e3d36524c3fe

Depends on D6227

Test Plan
ninja
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Fri, May 22, 19:34
Owners added a reviewer: Restricted Owners Package.Fri, May 22, 19:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, May 22, 19:34
nakihito requested review of this revision.Fri, May 22, 19:34
teamcity edited the summary of this revision. (Show Details)Fri, May 22, 19:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito updated this revision to Diff 20541.Fri, May 22, 19:42

Fixed some comment formatting.

deadalnix accepted this revision.Fri, May 22, 21:35
This revision is now accepted and ready to land.Fri, May 22, 21:35
This revision was automatically updated to reflect the committed changes.