Page MenuHomePhabricator

Refactor keymetadata writing to a separate method
ClosedPublic

Authored by nakihito on Thu, May 7, 20:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCeb725bf601e3: Refactor keymetadata writing to a separate method
Summary
Test Plan
ninja
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Thu, May 7, 20:18
Owners added a reviewer: Restricted Owners Package.Thu, May 7, 20:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 7, 20:18
nakihito requested review of this revision.Thu, May 7, 20:18
teamcity edited the summary of this revision. (Show Details)Thu, May 7, 20:18

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito planned changes to this revision.Thu, May 7, 20:23
nakihito updated this revision to Diff 20477.Thu, May 21, 19:02

Rebase.

nakihito planned changes to this revision.Thu, May 21, 19:47
nakihito requested review of this revision.Thu, May 21, 22:54
Fabien requested changes to this revision.Fri, May 22, 11:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/wallet/walletdb.cpp
84 ↗(On Diff #20477)

No overwrite

This revision now requires changes to proceed.Fri, May 22, 11:52
nakihito updated this revision to Diff 20522.Fri, May 22, 17:38

Fixed overwrite.

Fabien accepted this revision.Fri, May 22, 18:57
This revision is now accepted and ready to land.Fri, May 22, 18:57