Page MenuHomePhabricator
Differential D6204

Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
ClosedPublic
Actions

Authored by nakihito on May 21 2020, 19:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC179223f0b843: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
Summary

Creates new files util/bip32.h and util/bip32.cpp for containing
BIP 32 stuff.
Moves FormatKeyPath from descriptor.cpp to util/bip32.
Adds a wrapper around it to prepent the 'm' for when just the
BIP 32 style keypath is needed.

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/e7652d3f64212a6af68fc7d788411d28fcbdbd0a

Depends on D6004

Test Plan
../configure --enable-deprecated-build-system
make check

ninja
ninja check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.May 21 2020, 19:25
Owners added a reviewer: Restricted Owners Package.May 21 2020, 19:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 19:25
nakihito requested review of this revision.May 21 2020, 19:25
teamcity edited the summary of this revision. (Show Details)May 21 2020, 19:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)May 21 2020, 19:26
nakihito added a parent revision: D6004: Refactor keymetadata writing to a separate method.
teamcity added a comment.May 21 2020, 19:28

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 21 2020, 19:29

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 21 2020, 19:30

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 21 2020, 19:30

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 21 2020, 19:34

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 21 2020, 19:42

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10951: Diff 20480.May 21 2020, 19:42
nakihito planned changes to this revision.May 21 2020, 19:48
nakihito requested review of this revision.May 21 2020, 22:54
nakihito added a child revision: D6215: Test importing descriptors with key origin information and add release notes.May 21 2020, 22:58
Fabien requested changes to this revision.May 22 2020, 12:00
Fabien added a subscriber: Fabien.

Only nits

src/util/bip32.cpp
9 ↗(On Diff #20480)

Sort as per developer doc

57 ↗(On Diff #20480)

Braces

src/util/bip32.h
9 ↗(On Diff #20480)

Space between attributes.h and string

This revision now requires changes to proceed.May 22 2020, 12:00
nakihito updated this revision to Diff 20523.May 22 2020, 17:39

Fixed nits.

teamcity added a comment.May 22 2020, 17:45

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 22 2020, 17:46

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 22 2020, 17:47

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 22 2020, 17:47

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 22 2020, 17:51

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 22 2020, 17:58

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10977: Diff 20523.May 22 2020, 17:58
Fabien accepted this revision.May 22 2020, 18:58
This revision is now accepted and ready to land.May 22 2020, 18:58
nakihito added a child revision: D6227: Add a method to CWallet to write just CKeyMetadata.May 22 2020, 19:25
nakihito removed a child revision: D6215: Test importing descriptors with key origin information and add release notes.May 22 2020, 19:54
Closed by commit rABC179223f0b843: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} (authored by Andrew Chow <achow101-github@achow101.com>, committed by nakihito). · Explain WhyMay 22 2020, 22:47
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC179223f0b843: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
rpc/
1 line
script/
18 lines
util/
25 lines
68 lines
4 lines
42 lines
wallet/
1 line
test/
1 line
1 line

Diff 20553

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/util/bip32.h

Loading...
View Options

src/util/bip32.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/psbt_wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...