Page MenuHomePhabricator

Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
ClosedPublic

Authored by nakihito on May 21 2020, 19:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC179223f0b843: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
Summary

Creates new files util/bip32.h and util/bip32.cpp for containing
BIP 32 stuff.
Moves FormatKeyPath from descriptor.cpp to util/bip32.
Adds a wrapper around it to prepent the 'm' for when just the
BIP 32 style keypath is needed.

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/e7652d3f64212a6af68fc7d788411d28fcbdbd0a

Depends on D6004

Test Plan
../configure --enable-deprecated-build-system
make check

ninja
ninja check
test_runner.py

Event Timeline

nakihito created this revision.May 21 2020, 19:25
Owners added a reviewer: Restricted Owners Package.May 21 2020, 19:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 21 2020, 19:25
nakihito requested review of this revision.May 21 2020, 19:25
teamcity edited the summary of this revision. (Show Details)May 21 2020, 19:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito planned changes to this revision.May 21 2020, 19:48
nakihito requested review of this revision.May 21 2020, 22:54
Fabien requested changes to this revision.May 22 2020, 12:00
Fabien added a subscriber: Fabien.

Only nits

src/util/bip32.cpp
9

Sort as per developer doc

57

Braces

src/util/bip32.h
9

Space between attributes.h and string

This revision now requires changes to proceed.May 22 2020, 12:00
nakihito updated this revision to Diff 20523.May 22 2020, 17:39

Fixed nits.

Fabien accepted this revision.May 22 2020, 18:58
This revision is now accepted and ready to land.May 22 2020, 18:58