Page MenuHomePhabricator

Remove hdmasterkeyid
ClosedPublic

Authored by nakihito on May 1 2020, 22:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC63a0aeceba57: Remove hdmasterkeyid
Summary

Deprecated return results that were scheduled to be removed in v0.21

Partial backport of Core PR14021
https://github.com/bitcoin/bitcoin/pull/14021/commits/345bff6013e0d1a7eb0a08a071723b27f0460b77

Test Plan
ninja
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
removehdmasterkey
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 10549
Build 18909: Default Diff Build & Tests
Build 18908: arc lint + arc unit

Event Timeline

nakihito created this revision.May 1 2020, 22:53
Owners added a reviewer: Restricted Owners Package.May 1 2020, 22:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2020, 22:53
teamcity edited the summary of this revision. (Show Details)May 1 2020, 22:54

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 2 2020, 13:00
deadalnix added a subscriber: deadalnix.

This is part of a larger changeset that provide an alternative. Removing the feature without providing the alternative is not acceptable.

This revision now requires changes to proceed.May 2 2020, 13:00
deadalnix requested changes to this revision.May 9 2020, 19:33

The PR will have to be backported eventually, and having parts of it in will just make things more confusing for everybody involved. Please backport the whole PR.

And add release notes when you change the API.

This revision now requires changes to proceed.May 9 2020, 19:33
nakihito updated this revision to Diff 20482.May 21 2020, 19:37

Rebased and added release notes.

nakihito planned changes to this revision.May 21 2020, 19:47
nakihito requested review of this revision.May 21 2020, 22:58
deadalnix accepted this revision.May 22 2020, 21:21
This revision is now accepted and ready to land.May 22 2020, 21:21
This revision was automatically updated to reflect the committed changes.