[Fix] Allow connection of a noban banned peer
ClosedPublic
Actions

Authored by deadalnix on May 1 2020, 23:25.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING82899c9ef465: [Fix] Allow connection of a noban banned peer
rABC82899c9ef465: [Fix] Allow connection of a noban banned peer

Summary

Add test for setban

This is a backport of Core PR16618

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr16618

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10551
Build 18913: Default Diff Build & Tests
Build 18912: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 1 2020, 23:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2020, 23:25

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix added a child revision: D5936: QA: fix rpc_setban.py race.May 1 2020, 23:35

Harbormaster completed remote builds in B10551: Diff 19363.May 1 2020, 23:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Fabien mentioned this in D5928: Make whitebind/whitelist permissions more flexible.May 2 2020, 13:32

Fabien accepted this revision.May 2 2020, 13:38

This revision is now accepted and ready to land.May 2 2020, 13:38

Closed by commit rABC82899c9ef465: [Fix] Allow connection of a noban banned peer (authored by nicolas.dorier <nicolas.dorier@gmail.com>, committed by deadalnix). · Explain WhyMay 2 2020, 14:35

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC82899c9ef465: [Fix] Allow connection of a noban banned peer.

deadalnix added a commit: rSTAGING82899c9ef465: [Fix] Allow connection of a noban banned peer.May 5 2020, 19:17

Revision Contents
Changeset List

Path

Size

src/

net.cpp

6 lines

test/

functional/

rpc_setban.py

52 lines

Diff 19363

View Options

src/net.cpp