Page MenuHomePhabricator

Make whitebind/whitelist permissions more flexible
ClosedPublic

Authored by deadalnix on May 1 2020, 17:15.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.May 2 2020, 13:32
Fabien added a subscriber: Fabien.

Few nits, otherwise looks good

src/CMakeLists.txt
410 ↗(On Diff #19349)

Nit: _ is before a in the ascii table

src/Makefile.am
488 ↗(On Diff #19349)

Dito

src/net.cpp
985 ↗(On Diff #19349)

OK, D5935

src/net_permissions.h
6 ↗(On Diff #19349)

Not: newline to separate libs

61 ↗(On Diff #19349)

Newline

This revision now requires changes to proceed.May 2 2020, 13:32
This revision is now accepted and ready to land.May 2 2020, 13:51