Paths

Table of Contentst

Differential D5932

Replace the use of fWhitelisted by permission checks
ClosedPublic
Actions

Authored by deadalnix on May 1 2020, 22:47.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING2d7438dab2f4: Replace the use of fWhitelisted by permission checks
rABC2d7438dab2f4: Replace the use of fWhitelisted by permission checks

Summary

This is a partial backport of Core PR16248 : https://github.com/bitcoin/bitcoin/pull/16248/commits/d541fa391844f658bd7035659b5b16695733dd56

Depends on D5928

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 1 2020, 22:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2020, 22:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10548: Diff 19360.May 1 2020, 23:01

Please indicate dependency on D5928.

src/net_processing.cpp
2474 ↗	(On Diff #19360)	`PF_NOBAN` => `PF_RELAY`
2773 ↗	(On Diff #19360)	`PF_NOBAN` => `PF_RELAY`
2948 ↗	(On Diff #19360)	`PF_NOBAN` => `PF_FORCERELAY`
3558 ↗	(On Diff #19360)	`PF_NOBAN` => `PF_MEMPOOL`
3570 ↗	(On Diff #19360)	`PF_NOBAN` => `PF_MEMPOOL`
4834 ↗	(On Diff #19360)	`PF_NOBAN` => `PF_FORCERELAY`

This revision now requires changes to proceed.May 2 2020, 13:16

deadalnix edited the summary of this revision. (Show Details)May 2 2020, 13:18

deadalnix added a parent revision: D5928: Make whitebind/whitelist permissions more flexible.

deadalnix added inline comments.

src/net_processing.cpp
2474 ↗	(On Diff #19360)	Holly cow, I completely missed that it used a different flag every time. Good catch.

Use the proper flags

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.May 2 2020, 14:00

This revision is now accepted and ready to land.May 2 2020, 14:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10556: Diff 19370.May 2 2020, 14:08

Closed by commit rABC2d7438dab2f4: Replace the use of fWhitelisted by permission checks (authored by nicolas.dorier <nicolas.dorier@gmail.com>, committed by deadalnix). · Explain WhyMay 2 2020, 14:23

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC2d7438dab2f4: Replace the use of fWhitelisted by permission checks.

deadalnix added a commit: rSTAGING2d7438dab2f4: Replace the use of fWhitelisted by permission checks.May 5 2020, 19:17

Revision Contents
Changeset List

Path

Size

src/

7 lines

14 lines

net_processing.cpp

40 lines

qt/

4 lines

rpc/

2 lines

Diff 19373

src/net.h

Loading...

src/net.cpp

Loading...

src/net_processing.cpp

Loading...

src/qt/rpcconsole.cpp

Loading...

src/rpc/net.cpp

Loading...