Page MenuHomePhabricator
Differential D5928

Make whitebind/whitelist permissions more flexible
ClosedPublic
Actions

Authored by deadalnix on May 1 2020, 17:15.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING57ac9a6bbb37: Make whitebind/whitelist permissions more flexible
rABC57ac9a6bbb37: Make whitebind/whitelist permissions more flexible
Summary

This is a partial backport of Core PR16248 : https://github.com/bitcoin/bitcoin/pull/16248/commits/e5b26deaaa6842f7dd7c4537ede000f965ea0189

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16248-1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10555
Build 18921: Default Diff Build & Tests
Build 18920: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 1 2020, 17:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2020, 17:15
teamcity edited the summary of this revision. (Show Details)May 1 2020, 17:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 1 2020, 17:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 1 2020, 17:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10543: Diff 19349.May 1 2020, 17:26
Fabien mentioned this in D5932: Replace the use of fWhitelisted by permission checks.May 2 2020, 13:16
deadalnix added a child revision: D5932: Replace the use of fWhitelisted by permission checks.May 2 2020, 13:18
deadalnix added a child revision: D5929: Do not disconnect peer for asking mempool if it has NO_BAN permission.May 2 2020, 13:30
Fabien requested changes to this revision.May 2 2020, 13:32
Fabien added a subscriber: Fabien.

Few nits, otherwise looks good

src/CMakeLists.txt
410 ↗(On Diff #19349)

Nit: _ is before a in the ascii table

src/Makefile.am
488 ↗(On Diff #19349)

Dito

src/net.cpp
985 ↗(On Diff #19349)

OK, D5935

src/net_permissions.h
6 ↗(On Diff #19349)

Not: newline to separate libs

61 ↗(On Diff #19349)

Newline

This revision now requires changes to proceed.May 2 2020, 13:32
deadalnix updated this revision to Diff 19369.May 2 2020, 13:43

Address comments

teamcity added a comment.May 2 2020, 13:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.May 2 2020, 13:51
This revision is now accepted and ready to land.May 2 2020, 13:51
teamcity added a comment.May 2 2020, 13:54

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10555: Diff 19369.May 2 2020, 13:54
Closed by commit rABC57ac9a6bbb37: Make whitebind/whitelist permissions more flexible (authored by nicolas.dorier <nicolas.dorier@gmail.com>, committed by deadalnix). · Explain WhyMay 2 2020, 14:01
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC57ac9a6bbb37: Make whitebind/whitelist permissions more flexible.
deadalnix added a commit: rSTAGING57ac9a6bbb37: Make whitebind/whitelist permissions more flexible.May 5 2020, 19:17

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
23 lines
38 lines
77 lines
62 lines
139 lines
rpc/
7 lines
test/
115 lines

Diff 19369

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_permissions.h

Loading...
View Options

src/net_permissions.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/netbase_tests.cpp

Loading...