Page MenuHomePhabricator
Differential D5942

test: Adapt test framework for chains other than "regtest"
ClosedPublic
Actions

Authored by deadalnix on May 2 2020, 19:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb4d97684be91: test: Adapt test framework for chains other than "regtest"
rABCb4d97684be91: test: Adapt test framework for chains other than "regtest"
Summary
  • test: Fix “local variable 'e' is assigned to but never used”

flake8 F841 lints, as of flake8 3.6.0

  • test: Adapt test framework for chains other than "regtest"

Co-Authored-By: Jorge Timón <jtimon@jtimon.cc>

  • test: Avoid hardcoding the chain name in combine_logs

This is a backport of Core PR16509

The original PR contains a lot of formatting that was made obsolete by our process.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr16509
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10560
Build 18931: Default Diff Build & Tests
Build 18930: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 2 2020, 19:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2020, 19:34
teamcity edited the summary of this revision. (Show Details)May 2 2020, 19:34

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 2 2020, 19:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 2 2020, 19:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10560: Diff 19383.May 2 2020, 19:43
deadalnix requested review of this revision.May 2 2020, 19:43
deadalnix updated this revision to Diff 19384.May 2 2020, 22:17

restore host

teamcity added a comment.May 2 2020, 22:18

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 2 2020, 22:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10561: Diff 19384.May 2 2020, 22:27
Fabien accepted this revision.May 3 2020, 09:11
This revision is now accepted and ready to land.May 3 2020, 09:11
Closed by commit rABCb4d97684be91: test: Adapt test framework for chains other than "regtest" (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyMay 3 2020, 13:56
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb4d97684be91: test: Adapt test framework for chains other than "regtest".
deadalnix added a commit: rSTAGINGb4d97684be91: test: Adapt test framework for chains other than "regtest".May 5 2020, 19:18
PiRK mentioned this in D8738: Tests: Use self.chain instead of 'regtest' in all current tests.Dec 22 2020, 09:04
PiRK mentioned this in rABC736e9068fc07: Tests: Use self.chain instead of 'regtest' in all current tests.Dec 22 2020, 14:22

Revision Contents
Changeset List

PathSize
test/
functional/
15 lines
8 lines
2 lines
2 lines
test_framework/
12 lines
20 lines
20 lines

Diff 19383

View Options

test/functional/combine_logs.py

Loading...
View Options

test/functional/feature_blocksdir.py

Loading...
View Options

test/functional/interface_bitcoin_cli.py

Loading...
View Options

test/functional/rpc_bind.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...