Amount(long long) was ambiguous causing compile errors. Instantiation is now generalized to all integers
Details
Details
- Reviewers
schancel deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGINGf1a0dab0217c: Fix compile errors in Amount caused by ambiguous instantation
rABCf1a0dab0217c: Fix compile errors in Amount caused by ambiguous instantation
None; minor refactoring only
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D594
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 977 Build 977: arc lint + arc unit
Event Timeline
Comment Actions
I've added Amaury as a reviewer. He did not like using a template for some reason in previous revisions.
| src/amount.h | ||
|---|---|---|
| 22 ↗ | (On Diff #1533) | Originally I had used: template <typename T, typename std::enable_if<(std::is_integral<T>::value). T>::type = 0> rather than a static_assert You should include type_traits also I think? |
| src/amount.h | ||
|---|---|---|
| 22 ↗ | (On Diff #1533) | static assert sounds much clearer. is there a way to get an error message out of it ? |