Page MenuHomePhabricator

Make sure we read the command line inputs using utf-8 decoding in python
ClosedPublic

Authored by Fabien on May 5 2020, 07:41.

Details

Summary

Backport of core PR14128.

Extend our python encodings linter to cover check_output.

Test Plan
arc lint --everything

Remove one of the encodings arguments and run arc lint. Check the
linter returns an error.

Run the scripts.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested review of this revision.May 5 2020, 07:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 5 2020, 14:06
deadalnix added a subscriber: deadalnix.

That doesn't look like a backport of the PR.

This revision now requires changes to proceed.May 5 2020, 14:06
Fabien requested review of this revision.May 5 2020, 14:11
Fabien edited the summary of this revision. (Show Details)

Fixed PR number in the summary

This revision is now accepted and ready to land.May 5 2020, 18:33