Page MenuHomePhabricator
Differential D5957

Make sure we read the command line inputs using utf-8 decoding in python
ClosedPublic
Actions

Authored by Fabien on May 5 2020, 07:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4528a9a1bf3a: Make sure we read the command line inputs using utf-8 decoding in python
rABC4528a9a1bf3a: Make sure we read the command line inputs using utf-8 decoding in python
Summary

Backport of core PR14128.

Extend our python encodings linter to cover check_output.

Test Plan
arc lint --everything

Remove one of the encodings arguments and run arc lint. Check the
linter returns an error.

Run the scripts.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14128
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10583
Build 18976: Default Diff Build & Tests
Build 18975: arc lint + arc unit

Event Timeline

Fabien created this revision.May 5 2020, 07:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 07:41
Fabien requested review of this revision.May 5 2020, 07:41
teamcity edited the summary of this revision. (Show Details)May 5 2020, 07:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 5 2020, 07:41

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 5 2020, 07:58

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10583: Diff 19426.May 5 2020, 07:58
deadalnix requested changes to this revision.May 5 2020, 14:06
deadalnix added a subscriber: deadalnix.

That doesn't look like a backport of the PR.

This revision now requires changes to proceed.May 5 2020, 14:06
Fabien requested review of this revision.May 5 2020, 14:11
Fabien edited the summary of this revision. (Show Details)

Fixed PR number in the summary

deadalnix accepted this revision.May 5 2020, 18:33
This revision is now accepted and ready to land.May 5 2020, 18:33
Closed by commit rABC4528a9a1bf3a: Make sure we read the command line inputs using utf-8 decoding in python (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by Fabien). · Explain WhyMay 6 2020, 09:18
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4528a9a1bf3a: Make sure we read the command line inputs using utf-8 decoding in python.
Fabien added a commit: rSTAGING4528a9a1bf3a: Make sure we read the command line inputs using utf-8 decoding in python.May 6 2020, 14:35

Revision Contents
Changeset List

Diff 19426

View Options

arcanist/.phutil_module_cache

Loading...
View Options

arcanist/__phutil_library_map__.php

Loading...
View Options

arcanist/linter/PythonFileEncodingLinter.php

Loading...
View Options

arcanist/linter/PythonOpenFileEncodingLinter.php

Loading...
View Options

contrib/devtools/optimize-pngs.py

Loading...
View Options

src/config.cpp

Loading...
View Options

test/lint/check-doc.py

Loading...