Page MenuHomePhabricator

MalFix: Drop lookup in UTXO set to prevent unneeded relay
AbandonedPublic

Authored by jasonbcox on Oct 13 2017, 07:39.

Details

Reviewers
deadalnix
tomtomtom7
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

The code did a loose lookup in the UTXO set to see if a
transaction was already known to prevent some unneeded relaying.

This is no longer easily possible with MalFix and removed.

Test Plan

Logic removed wasn't covered by tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D597
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1004
Build 1004: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 13 2017, 07:39

Only change is 1079-1077. Is the policy on linter whitespace cleanup to always accept?

Please use clang-format 3.8 , it's impossible to figure out what you changed in there.

deadalnix requested changes to this revision.Oct 13 2017, 15:39

See comment on D596 . You are breaking a ton of stuff that don't need to be broken.

This revision now requires changes to proceed.Oct 13 2017, 15:39
tomtomtom7 edited edge metadata.

Fix linter to use clang-format-3.8

deadalnix requested changes to this revision.Dec 5 2017, 15:15

We need to have a flag on the CInv to differentiate id and hash.

This revision now requires changes to proceed.Dec 5 2017, 15:15
jasonbcox abandoned this revision.
jasonbcox added a reviewer: tomtomtom7.