MalFix: Drop lookup in UTXO set to prevent unneeded relay
AbandonedPublic
Actions

Authored by jasonbcox on Oct 13 2017, 07:39.

Details

Reviewers

deadalnix
tomtomtom7

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

The code did a loose lookup in the UTXO set to see if a
transaction was already known to prevent some unneeded relaying.

This is no longer easily possible with MalFix and removed.

Test Plan

Logic removed wasn't covered by tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 983
Build 983: arc lint + arc unit

Event Timeline

tomtomtom7 created this revision.Oct 13 2017, 07:39

Owners added a reviewer: Restricted Owners Package.Oct 13 2017, 07:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 13 2017, 07:39

Harbormaster completed remote builds in B983: Diff 1544.Oct 13 2017, 07:39

Only change is 1079-1077. Is the policy on linter whitespace cleanup to always accept?

Please use clang-format 3.8 , it's impossible to figure out what you changed in there.

See comment on D596 . You are breaking a ton of stuff that don't need to be broken.

This revision now requires changes to proceed.Oct 13 2017, 15:39

Fix linter to use clang-format-3.8

We need to have a flag on the CInv to differentiate id and hash.

This revision now requires changes to proceed.Dec 5 2017, 15:15

jasonbcox commandeered this revision.Apr 23 2019, 16:58

jasonbcox abandoned this revision.

jasonbcox added a reviewer: tomtomtom7.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

113 lines

Diff 1544

View Options

MalFix: Drop lookup in UTXO set to prevent unneeded relayAbandonedPublicActions