Page MenuHomePhabricator

Tweak RPC mempool benchmark so that perf improvements are more noticeable
AbandonedPublic

Authored by jasonbcox on May 6 2020, 05:38.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

The current RPC mempool benchmark test tests a small mempool of
only 1-in-1-out txs. To more broadly capture different classes of perf
improvements (such as changes to UniValue), we can expand the mempool size
a bit and bloat the number of inputs and outputs.

In future diffs, perf improvements have become much more measurable.

Inspired by https://gitlab.com/bitcoin-cash-node/bitcoin-cash-node/-/merge_requests/102
though I don't see value in keeping the old test.

Test Plan
ninja
./src/bench/bitcoin-bench -filter=RpcMempool

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bench-rpc-mempool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10603
Build 19016: Default Diff Build & Tests
Build 19015: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.May 6 2020, 15:03
deadalnix added a subscriber: deadalnix.

We start by testing something that is kind of realistic, even though it could be better (1000 txns, 1 to 1) to check for something that is completely contrived (10k txns, 100 to 100).

How is that an improvement?

This revision now requires changes to proceed.May 6 2020, 15:03

Also running the thing 3 time isn't going to give very reliable numbers.