Page MenuHomePhabricator

Move DisconnectResult in its own header and make it an enum class
ClosedPublic

Authored by deadalnix on May 7 2020, 16:08.

Details

Summary

This is required to expose CChainState to the public.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
discresultheader
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10636
Build 19079: Default Diff Build & Tests
Build 19078: arc lint + arc unit

Event Timeline

jasonbcox added a subscriber: jasonbcox.

I assume this work is related to https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d
We already own this part of the code due to D364 and that commit on Core appears to be shuffling DisconnectResult into validation.h which is not a good long-term solution.
This looks like the right approach, but the naming should change now that it sits on its own at the src level.

src/disconnectresult.h
8

Maybe ChainDisconnectResult? Without peering into this header, it could be anything. Networking, chain, etc.

This revision is now accepted and ready to land.May 7 2020, 16:45