Page MenuHomePhabricator
Differential D5995

Move DisconnectResult in its own header and make it an enum class
ClosedPublic
Actions

Authored by deadalnix on May 7 2020, 16:08.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa890296d4908: Move DisconnectResult in its own header and make it an enum class
rABCa890296d4908: Move DisconnectResult in its own header and make it an enum class
Summary

This is required to expose CChainState to the public.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
discresultheader
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10636
Build 19079: Default Diff Build & Tests
Build 19078: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 7 2020, 16:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2020, 16:08
deadalnix requested review of this revision.May 7 2020, 16:08
teamcity added a comment.May 7 2020, 16:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 7 2020, 16:20

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10636: Diff 19799.May 7 2020, 16:20
jasonbcox accepted this revision.May 7 2020, 16:45
jasonbcox added a subscriber: jasonbcox.

I assume this work is related to https://github.com/bitcoin/bitcoin/pull/15976/commits/d7c97edeea8cee10ad9da1f940d39d5073ac142d
We already own this part of the code due to D364 and that commit on Core appears to be shuffling DisconnectResult into validation.h which is not a good long-term solution.
This looks like the right approach, but the naming should change now that it sits on its own at the src level.

src/disconnectresult.h
8

Maybe ChainDisconnectResult? Without peering into this header, it could be anything. Networking, chain, etc.

This revision is now accepted and ready to land.May 7 2020, 16:45
Closed by commit rABCa890296d4908: Move DisconnectResult in its own header and make it an enum class (authored by deadalnix). · Explain WhyMay 7 2020, 17:17
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCa890296d4908: Move DisconnectResult in its own header and make it an enum class.
deadalnix added a commit: rSTAGINGa890296d4908: Move DisconnectResult in its own header and make it an enum class.May 7 2020, 17:20

Revision Contents
Changeset List

PathSize
src/
1 line
17 lines
10 lines
41 lines

Diff 19799

View Options

src/Makefile.am

Loading...
View Options

src/disconnectresult.h

Loading...
View Options

src/undo.h

Loading...
View Options

src/validation.cpp

Loading...