Page MenuHomePhabricator

Merge #12764: doc: Remove field in getblocktemplate help that has never been used.
ClosedPublic

Authored by jasonbcox on May 8 2020, 21:46.

Details

Summary

ac8a1d092e [RPC] Remove field in getblocktemplate help that has never been used (Conor Scott)

Pull request description:

[BIP 22 - getblocktemplate](https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki#Transactions%20Object%20Format) specifies an optional flag, `required` if the transaction must be in the block.

Luke's implementation #936 did not include this flag, and it was later added to the help description in #3246 (more than a year later) but the field was still never actually implemented. As far as I can tell, bitcoin core would have never actually included this in a `getblocktemplate` call, so it seems logical to remove it from the help description.

If I am missing something or this is considered harmless - I can close the PR.

Tree-SHA512: f25dda51cc4e1512aff69309be04e3053bdccc1cf03c8d58e8866aa1fdf9d86cc57df872e85528351fc8a8d6d64a8f46a36c513680834762d854f368fbeb0f44

Backport of Core PR12764

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12764
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10665
Build 19130: Default Diff Build & Tests
Build 19129: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.May 8 2020, 21:52