Page MenuHomePhabricator

Properly handle LONG_MIN in timedata.cpp
ClosedPublic

Authored by deadalnix on May 9 2020, 22:59.

Details

Summary

Because there is one more negative value possible than positive value, this code does not handle LONG_MIN properly. The obvious solution is to consider the absolute value unsigned (duh!).

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
unsignedabs64
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10675
Build 19147: Default Diff Build & Tests
Build 19146: arc lint + arc unit