Page MenuHomePhabricator
Differential D6028

[backport#14424] Stop requiring imported pubkey to sign non-PKH schemes
ClosedPublic
Actions

Authored by majcosta on May 11 2020, 15:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd8f89cfc896c: [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes
rABCd8f89cfc896c: [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes
Summary

...

This is a fix for https://github.com/bitcoin/bitcoin/issues/14415

This is a backport of Core PR14424

Test Plan
cmake .. -GENABLE_WERROR=ON -GNinja
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14424
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10684
Build 19165: Default Diff Build & Tests
Build 19164: arc lint + arc unit

Event Timeline

majcosta created this revision.May 11 2020, 15:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 15:07
majcosta requested review of this revision.May 11 2020, 15:07
teamcity edited the summary of this revision. (Show Details)May 11 2020, 15:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 11 2020, 15:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta added a child revision: D6029: [backport#14689] Require a public key to be retrieved when signing a P2PKH input.May 11 2020, 15:18
teamcity added a comment.May 11 2020, 15:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10684: Diff 19884.May 11 2020, 15:19
deadalnix accepted this revision.May 11 2020, 16:21
This revision is now accepted and ready to land.May 11 2020, 16:21
Closed by commit rABCd8f89cfc896c: [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by majcosta). · Explain WhyMay 11 2020, 16:56
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCd8f89cfc896c: [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes.
majcosta added a commit: rSTAGINGd8f89cfc896c: [backport#14424] Stop requiring imported pubkey to sign non-PKH schemes.May 11 2020, 17:00

Revision Contents
Changeset List

PathSize
src/
script/
20 lines

Diff 19884

View Options

src/script/sign.cpp

Loading...