Page MenuHomePhabricator

[backport#15632] [wallet] Schedule tx rebroadcasts in wallet
ClosedPublic

Authored by majcosta on May 11 2020, 16:53.

Details

Summary

Removes the now-unused Broadcast/ResendWalletTransactions interface from
validationinterface.

The wallet_resendwallettransactions.py needs a sleep added at the start
to make sure that the rebroadcast scheduler is warmed up before the next
block is mined.

https://github.com/bitcoin/bitcoin/pull/15632/commits/52b760fc6a9b26e405a0553ee8285b0f03ca1604


This is a partial backport of Core PR15632

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 11 2020, 16:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 16:53
majcosta requested review of this revision.May 11 2020, 16:53
teamcity edited the summary of this revision. (Show Details)May 11 2020, 16:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.May 11 2020, 17:10
This revision is now accepted and ready to land.May 11 2020, 17:10
deadalnix added inline comments.May 11 2020, 17:11
test/functional/wallet_resendwallettransactions.py
48 ↗(On Diff #19893)

visibledisgust