Page MenuHomePhabricator
Differential D6031

[backport#15632] [wallet] Schedule tx rebroadcasts in wallet
ClosedPublic
Actions

Authored by majcosta on May 11 2020, 16:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa044299f76be: [backport#15632] [wallet] Schedule tx rebroadcasts in wallet
rABCa044299f76be: [backport#15632] [wallet] Schedule tx rebroadcasts in wallet
Summary

Removes the now-unused Broadcast/ResendWalletTransactions interface from
validationinterface.

The wallet_resendwallettransactions.py needs a sleep added at the start
to make sure that the rebroadcast scheduler is warmed up before the next
block is mined.

https://github.com/bitcoin/bitcoin/pull/15632/commits/52b760fc6a9b26e405a0553ee8285b0f03ca1604

This is a partial backport of Core PR15632

Test Plan
cmake .. -GNinja -DENABLE_WERROR=ON
ninja check-all

Diff Detail

Event Timeline

majcosta created this revision.May 11 2020, 16:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2020, 16:53
majcosta requested review of this revision.May 11 2020, 16:53
teamcity edited the summary of this revision. (Show Details)May 11 2020, 16:53

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 11 2020, 16:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 11 2020, 17:04

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10691: Diff 19893.May 11 2020, 17:04
deadalnix accepted this revision.May 11 2020, 17:10
This revision is now accepted and ready to land.May 11 2020, 17:10
deadalnix added inline comments.May 11 2020, 17:11
test/functional/wallet_resendwallettransactions.py
48

visibledisgust

Closed by commit rABCa044299f76be: [backport#15632] [wallet] Schedule tx rebroadcasts in wallet (authored by John Newbery <john@johnnewbery.com>, committed by majcosta). · Explain WhyMay 11 2020, 17:53
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCa044299f76be: [backport#15632] [wallet] Schedule tx rebroadcasts in wallet.
majcosta added a commit: rSTAGINGa044299f76be: [backport#15632] [wallet] Schedule tx rebroadcasts in wallet.

Revision Contents
Changeset List

PathSize
src/
interfaces/
4 lines
12 lines
7 lines
3 lines
9 lines
wallet/
8 lines
10 lines
22 lines
test/
functional/
6 lines

Diff 19893

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/validationinterface.h

Loading...
View Options

src/validationinterface.cpp

Loading...
View Options

src/wallet/load.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_resendwallettransactions.py

Loading...