Page MenuHomePhabricator

[backport#13932] Implement utxoupdatepsbt RPC and tests
ClosedPublic

Authored by majcosta on May 12 2020, 15:20.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 12 2020, 15:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 15:20
majcosta requested review of this revision.May 12 2020, 15:20
teamcity edited the summary of this revision. (Show Details)May 12 2020, 15:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added inline comments.
test/functional/rpc_psbt.py
27 ↗(On Diff #19948)

It looks like you removed it anyways. Does this work?

majcosta added inline comments.May 12 2020, 16:05
test/functional/rpc_psbt.py
27 ↗(On Diff #19948)

yes, with or without -txindex.

deadalnix requested changes to this revision.May 12 2020, 16:30
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
1746 ↗(On Diff #19948)

This belongs inside the loop.

1756 ↗(On Diff #19948)

size_t

1756 ↗(On Diff #19948)

This loop skip over non null utxos.

test/functional/rpc_psbt.py
27 ↗(On Diff #19948)

Well then... Update accordingly.

This revision now requires changes to proceed.May 12 2020, 16:30
majcosta updated this revision to Diff 19955.May 12 2020, 19:17

addressed comments, left in TODO comment in rpc_psbt.py for now (to be removed in https://github.com/bitcoin/bitcoin/pull/15404)

majcosta retitled this revision from [backport#13939] Implement utxoupdatepsbt RPC and tests to [backport#13932] Implement utxoupdatepsbt RPC and tests.May 12 2020, 20:01
deadalnix requested changes to this revision.May 12 2020, 21:02
deadalnix added inline comments.
test/functional/rpc_psbt.py
27 ↗(On Diff #19955)

It doesn't look like there is any call to getrawtransaction as you pointed out, this doesn't seems to be required here. So quite clearly, something is missing somewhere. Adding random flags is not the solution.

This revision now requires changes to proceed.May 12 2020, 21:02
majcosta updated this revision to Diff 19960.May 12 2020, 21:26

removed unnecessary -txindex in tests

deadalnix accepted this revision.May 13 2020, 00:01
This revision is now accepted and ready to land.May 13 2020, 00:01