Page MenuHomePhabricator

[backport#13932] Figure out what is missing during signing
ClosedPublic

Authored by majcosta on May 12 2020, 21:21.

Details

Summary

When signing an input, figure out what was requested for but was unable
to be found and store it in a SignatureData.

Return this information in SignPSBTInput.

https://github.com/bitcoin/bitcoin/pull/13932/commits/cb40b3abd4514361a024a1e7a1a281da9261261b


Depends on D6045

This is a partial backport of Core PR13932

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 12 2020, 21:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 21:21
majcosta requested review of this revision.May 12 2020, 21:21
teamcity edited the summary of this revision. (Show Details)May 12 2020, 21:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.May 12 2020, 23:14
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/script/sign.h
139 ↗(On Diff #19959)

Move comment on the previous line.

This revision now requires changes to proceed.May 12 2020, 23:14
nakihito requested changes to this revision.May 13 2020, 01:07
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/psbt.cpp
214 ↗(On Diff #19959)

This looks missing?

src/script/sign.h
134–139 ↗(On Diff #19959)

Comments on their own lines.

majcosta updated this revision to Diff 19990.May 13 2020, 13:37

added missing code, moved comments to their own lines

deadalnix accepted this revision.May 13 2020, 14:48
nakihito accepted this revision.May 13 2020, 17:03
This revision is now accepted and ready to land.May 13 2020, 17:03