Page MenuHomePhabricator
Differential D6046

[backport#13932] Figure out what is missing during signing
ClosedPublic
Actions

Authored by majcosta on May 12 2020, 21:21.

Details

Reviewers
deadalnix
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING63fa706bb630: [backport#13932] Figure out what is missing during signing
rABC63fa706bb630: [backport#13932] Figure out what is missing during signing
Summary

When signing an input, figure out what was requested for but was unable
to be found and store it in a SignatureData.

Return this information in SignPSBTInput.

https://github.com/bitcoin/bitcoin/pull/13932/commits/cb40b3abd4514361a024a1e7a1a281da9261261b

Depends on D6045

This is a partial backport of Core PR13932

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 12 2020, 21:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 12 2020, 21:21
majcosta requested review of this revision.May 12 2020, 21:21
teamcity edited the summary of this revision. (Show Details)May 12 2020, 21:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 12 2020, 21:21

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 12 2020, 21:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10721: Diff 19959.May 12 2020, 21:31
deadalnix requested changes to this revision.May 12 2020, 23:14
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/script/sign.h
139 ↗(On Diff #19959)

Move comment on the previous line.

This revision now requires changes to proceed.May 12 2020, 23:14
nakihito requested changes to this revision.May 13 2020, 01:07
nakihito added a subscriber: nakihito.
nakihito added inline comments.
src/psbt.cpp
214 ↗(On Diff #19959)

This looks missing?

src/script/sign.h
134–139 ↗(On Diff #19959)

Comments on their own lines.

majcosta updated this revision to Diff 19990.May 13 2020, 13:37

added missing code, moved comments to their own lines

teamcity added a comment.May 13 2020, 13:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 13 2020, 13:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 13 2020, 13:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 13 2020, 13:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10737: Diff 19990.May 13 2020, 13:53
deadalnix accepted this revision.May 13 2020, 14:48
nakihito accepted this revision.May 13 2020, 17:03
This revision is now accepted and ready to land.May 13 2020, 17:03
Closed by commit rABC63fa706bb630: [backport#13932] Figure out what is missing during signing (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyMay 13 2020, 17:16
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC63fa706bb630: [backport#13932] Figure out what is missing during signing.
majcosta added a commit: rSTAGING63fa706bb630: [backport#13932] Figure out what is missing during signing.May 13 2020, 17:20

Revision Contents
Changeset List

PathSize
src/
4 lines
25 lines
script/
6 lines
10 lines

Diff 20006

View Options

src/psbt.h

Loading...
View Options

src/psbt.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...