Details
- Reviewers
deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGING41707be22c38: Partial Merge #14454: ProcessImport() cleanup (excluding witness)
rABC41707be22c38: Partial Merge #14454: ProcessImport() cleanup (excluding witness)
ninja ninja check ninja check-functional
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.
| src/wallet/rpcdump.cpp | ||
|---|---|---|
| 1119–1123 ↗ | (On Diff #19974) | This change is made in PR9332. |
| 1253–1257 ↗ | (On Diff #19974) | This is the reapplication of PR14679. |
| 1269–1278 ↗ | (On Diff #19974) | This is removed in PR9332. |
| 1345–1355 ↗ | (On Diff #19974) | This is removed in PR9332. |
| 1396–1401 ↗ | (On Diff #19974) | |
| test/functional/wallet_importmulti.py | ||
| 94–107 ↗ | (On Diff #19974) | This change was made in PR14454. |
| 109–123 ↗ | (On Diff #19974) | This change was made in PR9332. |
| 163–177 ↗ | (On Diff #19974) | This change was made in PR9332. |
| 227–229 ↗ | (On Diff #19974) | These changes were made in PR14454. |
| 251–264 ↗ | (On Diff #19974) | This change was made in PR9332. |
I started reviewing this but this is incredibly difficult. If the problem backport PR9332 is that some test is broken, isn't it possible to modify the PR slightly so that it doesn't break the test?
Looks like the importmulti function test is inconsistent on the machine I was using. I have uploaded D6061 which backports only a modified PR9332 which I tested on one of the dev boxes. I'll update this one to only backport the non-witness parts of PR14454.