Page MenuHomePhabricator

Merge #9332: Let wallet importmulti RPC accept labels for standard scriptPubKeys
ClosedPublic

Authored by nakihito on May 13 2020, 18:18.

Details

Summary

98ea64cf232c34d4b1aebe738b3956191667cd76 Let wallet importmulti RPC accept labels for standard scriptPubKeys (Russell Yanofsky)

Pull request description:

Allow importmulti RPC to apply address labels when importing standard scriptPubKeys. This makes the importmulti RPC less finnicky about import formats and also simpler internally.

Tree-SHA512: 102426b21239f1fa5f38162dc3f4145572caef76e63906afd786b7aff1670d6cd93456f8d85f737588eedc49c11bef2e1e8019b8b2cbf6097c77b3501b0cab1f

Backport of Core PR9332
I also had to reapply a change from PR14679

Test Plan
ninja
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.May 13 2020, 18:18
Owners added a reviewer: Restricted Owners Package.May 13 2020, 18:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2020, 18:18
nakihito requested review of this revision.May 13 2020, 18:18
nakihito planned changes to this revision.
teamcity edited the summary of this revision. (Show Details)May 13 2020, 18:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested review of this revision.May 13 2020, 18:28
nakihito added inline comments.May 14 2020, 20:09
nakihito edited the summary of this revision. (Show Details)May 14 2020, 20:10
Fabien accepted this revision.May 14 2020, 20:13
This revision is now accepted and ready to land.May 14 2020, 20:13