Page MenuHomePhabricator
Differential D6072

[backport#13769] Mark single-argument constructors "explicit"
ClosedPublic
Actions

Authored by majcosta on May 14 2020, 17:21.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING1d9e07db1be6: [backport#13769] Mark single-argument constructors "explicit"
rABC1d9e07db1be6: [backport#13769] Mark single-argument constructors "explicit"
Summary

https://github.com/bitcoin/bitcoin/pull/13769/commits/1ac3c983bfe06f75542e4f4e30142952802a46d8

This is a backport of Core PR13769

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 14 2020, 17:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 17:21
majcosta requested review of this revision.May 14 2020, 17:21
teamcity edited the summary of this revision. (Show Details)May 14 2020, 17:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 14 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 14 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 14 2020, 17:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 14 2020, 17:23

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 14 2020, 17:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 14 2020, 17:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10764: Diff 20048.May 14 2020, 17:32
nakihito accepted this revision.May 14 2020, 18:24
This revision is now accepted and ready to land.May 14 2020, 18:24
majcosta added a child revision: D6073: [backport#14906] refactor: Make explicit CMutableTransaction -> CTransaction conversion..May 14 2020, 19:07
Closed by commit rABC1d9e07db1be6: [backport#13769] Mark single-argument constructors "explicit" (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by majcosta). · Explain WhyMay 16 2020, 11:39
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC1d9e07db1be6: [backport#13769] Mark single-argument constructors "explicit".
majcosta added a commit: rSTAGING1d9e07db1be6: [backport#13769] Mark single-argument constructors "explicit".

Revision Contents
Changeset List

Diff 20156

View Options

src/interfaces/handler.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/key_io.cpp

Loading...
View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/validation_block_tests.cpp

Loading...