Page MenuHomePhabricator

[backport#14906] refactor: Make explicit CMutableTransaction -> CTransaction conversion.
ClosedPublic

Authored by majcosta on May 14 2020, 19:07.

Details

Summary

This PR is re-submission of #14156, which was automatically closed by github (glitch?)

Original description:

This PR makes explicit the now implicit conversion constructor CTransaction(const CMutableTransaction&) in transaction.h.
Minimal changes were made elsewhere to make the code compilable. I'll follow up with other PRs to address individually refactoring functions that should have a CMutableTransaction version, or where a CTransaction should be reused.

The rationale for this change is:

Conversion constructors should not be explicit unless there's a strong reason for it (in the opinion of, for example, https://google.github.io/styleguide/cppguide.html, and https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ro-conversion. Let me know your take on this).
This particular conversion is very costly -- it implies a serialization plus hash of the transaction.
Even though CTransaction and CMutableTransaction represent the same data, they have very different use cases and performance properties.
Making it explicit allows for easier reasoning of performance trade-offs.
There has been previous performance issues caused by unneeded use of this implicit conversion.
This PR creates a map for places to look for possible refactoring and performance gains (this benefit still holds if the PR is not merged).


Depends on D6072

This is a backport of Core PR14906

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.May 14 2020, 19:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:07
majcosta requested review of this revision.May 14 2020, 19:07
teamcity edited the summary of this revision. (Show Details)May 14 2020, 19:07

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested changes to this revision.May 14 2020, 19:44
nakihito added a subscriber: nakihito.

Backport doesn't match the original PR.

This revision now requires changes to proceed.May 14 2020, 19:44
majcosta requested review of this revision.May 14 2020, 20:01

Most of the changes in the original backport were already done in D1106, except for a few changes related to PartiallySignedTransactions, which we already moved so that is why the files changed are different. The line change in wallet/rpcwallet.cpp also just brings up to parity with Core.

nakihito accepted this revision.May 14 2020, 20:24

Most of the changes in the original backport were already done in D1106, except for a few changes related to PartiallySignedTransactions, which we already moved so that is why the files changed are different. The line change in wallet/rpcwallet.cpp also just brings up to parity with Core.

Definitely make note of this next time.

src/wallet/rpcwallet.cpp
4807 ↗(On Diff #20052)

Out-of-order backport: D5715

This revision is now accepted and ready to land.May 14 2020, 20:24