Page MenuHomePhabricator

Remove Core release note file, update previous release notes, and fix generate() deprecation message
ClosedPublic

Authored by nakihito on May 14 2020, 19:22.

Details

Summary

The core release note file was added rather than adding the release
notes to our file in D5971. This also adjusts the version numbers to match our
own both in the release notes and in the rpc code.

Test Plan
ninja
./bitcoind
./bitcoin-cli generate 1

Verify the correct version numbers in the RPC deprecated message.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.May 14 2020, 19:22
Owners added a reviewer: Restricted Owners Package.May 14 2020, 19:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:22
nakihito requested review of this revision.May 14 2020, 19:22
nakihito edited the summary of this revision. (Show Details)May 14 2020, 19:26
jasonbcox requested changes to this revision.May 14 2020, 19:29
jasonbcox added a subscriber: jasonbcox.

Good catch.

doc/release-notes.md
7 ↗(On Diff #20054)

I don't think this patch needs its own release notes. It's a very minor bug fix.

If you insist on including it, at least provide a markdown link that will render well on Github.

This revision now requires changes to proceed.May 14 2020, 19:29
nakihito updated this revision to Diff 20056.May 14 2020, 19:32

Removed note from current release notes.

jasonbcox accepted this revision.May 14 2020, 19:34
This revision is now accepted and ready to land.May 14 2020, 19:34
nakihito updated this revision to Diff 20057.May 14 2020, 19:34

Actually remove the Core release note file.

jasonbcox accepted this revision.May 14 2020, 19:35