Page MenuHomePhabricator
Differential D5971

[wallet] Deprecate the generate RPC method
ClosedPublic
Actions

Authored by deadalnix on May 5 2020, 23:56.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGING8aa2e9378598: [wallet] Deprecate the generate RPC method
rABC8aa2e9378598: [wallet] Deprecate the generate RPC method
Summary

This is a partial backport of Core PR14468 : https://github.com/bitcoin/bitcoin/pull/14468/commits/c9f02955b2e9062808a9455c4ee7d52cf401eef5

Depends on D5970

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 5 2020, 23:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 5 2020, 23:56
deadalnix requested review of this revision.May 5 2020, 23:56
teamcity edited the summary of this revision. (Show Details)May 5 2020, 23:56

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 5 2020, 23:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix added a child revision: D5972: [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text..May 6 2020, 00:02
teamcity added a comment.May 6 2020, 00:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10600: Diff 19708.May 6 2020, 00:07
majcosta accepted this revision as: majcosta.May 6 2020, 08:44
majcosta added a subscriber: majcosta.

nit: change messages to "*will be fully deprecated in 0.22*" (or 0.23, whichever is right) and "To continue using generate in 0.21.6*"

This revision is now accepted and ready to land.May 6 2020, 08:44
Closed by commit rABC8aa2e9378598: [wallet] Deprecate the generate RPC method (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 6 2020, 13:57
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC8aa2e9378598: [wallet] Deprecate the generate RPC method.
deadalnix added a commit: rSTAGING8aa2e9378598: [wallet] Deprecate the generate RPC method.May 6 2020, 14:35
nakihito mentioned this in D6074: Remove Core release note file, update previous release notes, and fix generate() deprecation message.May 14 2020, 19:26
nakihito mentioned this in rABC76d513094857: Remove Core release note file, update previous release notes, and fix generate….May 14 2020, 19:48
nakihito mentioned this in rSTAGING76d513094857: Remove Core release note file, update previous release notes, and fix generate….

Revision Contents
Changeset List

PathSize
doc/
15 lines
src/
wallet/
10 lines
test/
functional/
12 lines
4 lines

Diff 19729

View Options

doc/release-notes-14468.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...
View Options

test/functional/rpc_signrawtransaction.py

Loading...