Page MenuHomePhabricator
Differential D5973

[tests] Move deterministic address import to setup_nodes
ClosedPublic
Actions

Authored by deadalnix on May 6 2020, 00:48.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGING04a267981699: [tests] Move deterministic address import to setup_nodes
rABC04a267981699: [tests] Move deterministic address import to setup_nodes
Summary

This requires a small changes to a few tests, but means that
deterministic addresses will always be imported (unless setup_nodes
behaviour is explicitly overridden).

This is a backport of Core PR14631

Depends on D5972

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 6 2020, 00:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 00:48
deadalnix requested review of this revision.May 6 2020, 00:48
teamcity edited the summary of this revision. (Show Details)May 6 2020, 00:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 6 2020, 00:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 6 2020, 00:57

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10602: Diff 19710.May 6 2020, 00:57
Fabien added a subscriber: Fabien.May 6 2020, 08:57

The changes to rpc_signrawtransaction.py seems unrelated to this change, it is necessary ? Otherwise LGTM.

majcosta added a subscriber: majcosta.May 6 2020, 09:06
majcosta added inline comments.
test/functional/rpc_signrawtransaction.py
17 ↗(On Diff #19710)

the original commit doesn't touch this test, is this right?

deadalnix updated this revision to Diff 19725.May 6 2020, 13:24

rebase

teamcity added a comment.May 6 2020, 13:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta accepted this revision.May 6 2020, 13:29
This revision is now accepted and ready to land.May 6 2020, 13:29
teamcity added a comment.May 6 2020, 13:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10610: Diff 19725.May 6 2020, 13:34
Closed by commit rABC04a267981699: [tests] Move deterministic address import to setup_nodes (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 6 2020, 14:24
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC04a267981699: [tests] Move deterministic address import to setup_nodes.
deadalnix added a commit: rSTAGING04a267981699: [tests] Move deterministic address import to setup_nodes.May 6 2020, 14:35

Revision Contents
Changeset List

Diff 19731

View Options

test/functional/feature_dbcrash.py

Loading...
View Options

test/functional/feature_pruning.py

Loading...
View Options

test/functional/interface_zmq.py

Loading...
View Options

test/functional/p2p_node_network_limited.py

Loading...
View Options

test/functional/rpc_signrawtransaction.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/tool_wallet.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...
View Options

test/functional/wallet_import_rescan.py

Loading...
View Options

test/functional/wallet_listreceivedby.py

Loading...