[rpc] add 'getnewaddress' hint to 'generatetoaddress' help text.
ClosedPublic
Actions

Authored by deadalnix on May 6 2020, 00:02.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd6f5209927e6: [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text.
rABCd6f5209927e6: [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text.

Summary

Final step of PR14468

Depends on D5971

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 6 2020, 00:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2020, 00:02

deadalnix requested review of this revision.May 6 2020, 00:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10601: Diff 19709.May 6 2020, 00:12

deadalnix added a child revision: D5973: [tests] Move deterministic address import to setup_nodes.May 6 2020, 00:48

HelpExampleCli("getnewaddress", "") hint is missing

This revision now requires changes to proceed.May 6 2020, 08:49

Add getnewaddress exemple

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10608: Diff 19722.May 6 2020, 13:30

majcosta accepted this revision.May 6 2020, 13:30

This revision is now accepted and ready to land.May 6 2020, 13:30

Closed by commit rABCd6f5209927e6: [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text. (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyMay 6 2020, 14:07

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCd6f5209927e6: [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text..

deadalnix added a commit: rSTAGINGd6f5209927e6: [rpc] add 'getnewaddress' hint to 'generatetoaddress' help text..May 6 2020, 14:35

Revision Contents
Changeset List

Path

Size

src/

rpc/

mining.cpp

5 lines

Diff 19730

View Options

[rpc] add 'getnewaddress' hint to 'generatetoaddress' help text.ClosedPublicActions