Remove Core release note file, update previous release notes, and fix generate() deprecation message
ClosedPublic
Actions

Authored by nakihito on May 14 2020, 19:22.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING76d513094857: Remove Core release note file, update previous release notes, and fix generate…
rABC76d513094857: Remove Core release note file, update previous release notes, and fix generate…

Summary

The core release note file was added rather than adding the release
notes to our file in D5971. This also adjusts the version numbers to match our
own both in the release notes and in the rpc code.

Test Plan

ninja
./bitcoind
./bitcoin-cli generate 1

Verify the correct version numbers in the RPC deprecated message.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

releasenotesfix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10767
Build 19370: Default Diff Build & Tests
Build 19369: Build without Wallet
Build 19368: Build with clang-10
Build 19367: arc lint + arc unit

Event Timeline

nakihito created this revision.May 14 2020, 19:22

Owners added a reviewer: Restricted Owners Package.May 14 2020, 19:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 14 2020, 19:22

nakihito requested review of this revision.May 14 2020, 19:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

nakihito edited the summary of this revision. (Show Details)May 14 2020, 19:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Good catch.

doc/release-notes.md
7	I don't think this patch needs its own release notes. It's a very minor bug fix. If you insist on including it, at least provide a markdown link that will render well on Github.