Page MenuHomePhabricator
Differential D6094

Add checkpoints for phonon activation
ClosedPublic
Actions

Authored by Fabien on May 15 2020, 18:17.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGfca23c6355e1: Add checkpoints for phonon activation
rABCfca23c6355e1: Add checkpoints for phonon activation
Summary

As per title.

Test Plan

Check against your nodes and run IBD on mainnet and testnet.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 15 2020, 18:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 15 2020, 18:17
Fabien requested review of this revision.May 15 2020, 18:17
jasonbcox accepted this revision.May 15 2020, 18:37
This revision is now accepted and ready to land.May 15 2020, 18:37
teamcity added a comment.May 15 2020, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 15 2020, 18:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 15 2020, 18:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 15 2020, 18:48

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Harbormaster completed remote builds in B10792: Diff 20116.May 15 2020, 18:48
teamcity added a comment.May 15 2020, 18:48
Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[18:48:09]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-15T18:47:58.483000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-15T18:47:58.533000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:47:58.533000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/wallet_txn_clone_566 on exit
2020-05-15T18:47:58.533000Z TestFramework (INFO): Test skipped
[18:48:09]i:		 [Bitcoin ABC functional tests] wallet_txn_clone.py --mineblock
[18:48:09]i:			 [wallet_txn_clone.py --mineblock] Test ignored: wallet_txn_clone.py --mineblock
[18:48:09]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-15T18:47:50.413000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-15T18:47:50.464000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:47:50.464000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/wallet_txn_clone_547 on exit
2020-05-15T18:47:50.464000Z TestFramework (INFO): Test skipped
[18:48:09]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py
[18:48:09]i:			 [wallet_txn_doublespend.py] Test ignored: wallet_txn_doublespend.py
[18:48:09]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-15T18:48:05.680000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-15T18:48:05.730000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:48:05.730000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/wallet_txn_doublespend_600 on exit
2020-05-15T18:48:05.731000Z TestFramework (INFO): Test skipped
[18:48:09]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py --mineblock
[18:48:09]i:			 [wallet_txn_doublespend.py --mineblock] Test ignored: wallet_txn_doublespend.py --mineblock
[18:48:09]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-15T18:47:50.553000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-15T18:47:50.603000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:47:50.603000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/wallet_txn_doublespend_548 on exit
2020-05-15T18:47:50.603000Z TestFramework (INFO): Test skipped
[18:48:09]i:		 [Bitcoin ABC functional tests] wallet_zapwallettxes.py
[18:48:09]i:			 [wallet_zapwallettxes.py] Test ignored: wallet_zapwallettxes.py
[18:48:09]i:		 [Bitcoin ABC functional tests] [Test Output]
2020-05-15T18:47:43.909000Z TestFramework (WARNING): Test Skipped: wallet has not been compiled.
2020-05-15T18:47:43.960000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:47:43.960000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/wallet_zapwallettxes_533 on exit
2020-05-15T18:47:43.960000Z TestFramework (INFO): Test skipped
[18:48:09]i:		 [Bitcoin ABC functional tests] abc-miner-fund.py
[18:48:09]i:			 [abc-miner-fund.py] [Test Output]
2020-05-15T18:47:23.236000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/abc-miner-fund_512
2020-05-15T18:47:23.494000Z TestFramework (INFO): Create some old blocks
2020-05-15T18:47:24.044000Z TestFramework (INFO): Testing miner fund minerfund on bit 0.
2020-05-15T18:47:24.734000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 163, in main
    self.run_test()
  File "/work/test/functional/abc-miner-fund.py", line 82, in run_test
    run_test_for(0, 'minerfund', MINER_FUND_ADDR)
  File "/work/test/functional/abc-miner-fund.py", line 80, in run_test_for
    self.run_miner_fund_test(bit, name, address)
  File "/work/test/functional/abc-miner-fund.py", line 143, in run_miner_fund_test
    'since': 432,
  File "/work/test/functional/abc-miner-fund.py", line 40, in check_bip9_state
    assert_equal(miner_fund_info['bip9'], status)
  File "/work/test/functional/test_framework/util.py", line 50, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not({'status': 'failed', 'start_time': 1573819200, 'timeout': 1589544000, 'since': 432} == {'status': 'locked_in', 'start_time': 1573819200, 'timeout': 1589544000, 'since': 432})
2020-05-15T18:47:24.785000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:47:24.986000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/abc-miner-fund_512
2020-05-15T18:47:24.986000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/test_runner_₿₵_  _20200515_184721/abc-miner-fund_512/test_framework.log
2020-05-15T18:47:24.986000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/test_runner_₿₵_  _20200515_184721/abc-miner-fund_512' to consolidate all logs
[18:48:15]E:	 [Step 1/2] Failed tests detected
[18:48:16]W:	 [Step 1/2] Process exited with code 1
[18:48:16]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-miner-fund.py

Fabien updated this revision to Diff 20118.May 15 2020, 18:52

Rebase for CI

teamcity added a comment.May 15 2020, 18:55
Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

2020-05-15T18:53:16.827000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_resendwallettransactions_345 on exit
2020-05-15T18:53:16.827000Z TestFramework (INFO): Tests successful
[18:54:46]i:		 [Bitcoin ABC functional tests] wallet_txn_clone.py
[18:54:46]i:			 [wallet_txn_clone.py] [Test Output]
2020-05-15T18:54:26.419000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_clone_411
2020-05-15T18:54:28.546000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:54:28.858000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_clone_411 on exit
2020-05-15T18:54:28.858000Z TestFramework (INFO): Tests successful
[18:54:46]i:		 [Bitcoin ABC functional tests] wallet_txn_clone.py --mineblock
[18:54:46]i:			 [wallet_txn_clone.py --mineblock] [Test Output]
2020-05-15T18:54:16.352000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_clone_392
2020-05-15T18:54:19.501000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:54:19.808000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_clone_392 on exit
2020-05-15T18:54:19.808000Z TestFramework (INFO): Tests successful
[18:54:46]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py
[18:54:46]i:			 [wallet_txn_doublespend.py] [Test Output]
2020-05-15T18:54:37.900000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_doublespend_445
2020-05-15T18:54:38.951000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:54:39.155000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_doublespend_445 on exit
2020-05-15T18:54:39.155000Z TestFramework (INFO): Tests successful
[18:54:46]i:		 [Bitcoin ABC functional tests] wallet_txn_doublespend.py --mineblock
[18:54:46]i:			 [wallet_txn_doublespend.py --mineblock] [Test Output]
2020-05-15T18:54:16.842000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_doublespend_393
2020-05-15T18:54:19.990000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:54:20.296000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_txn_doublespend_393 on exit
2020-05-15T18:54:20.296000Z TestFramework (INFO): Tests successful
[18:54:46]i:		 [Bitcoin ABC functional tests] wallet_zapwallettxes.py
[18:54:46]i:			 [wallet_zapwallettxes.py] [Test Output]
2020-05-15T18:54:04.500000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_zapwallettxes_378
2020-05-15T18:54:04.922000Z TestFramework (INFO): Mining blocks...
2020-05-15T18:54:07.907000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:54:08.159000Z TestFramework (INFO): Cleaning up /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/wallet_zapwallettxes_378 on exit
2020-05-15T18:54:08.159000Z TestFramework (INFO): Tests successful
[18:54:46]i:		 [Bitcoin ABC functional tests] abc-miner-fund.py
[18:54:46]i:			 [abc-miner-fund.py] [Test Output]
2020-05-15T18:53:38.843000Z TestFramework (INFO): Initializing test directory /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/abc-miner-fund_357
2020-05-15T18:53:39.118000Z TestFramework (INFO): Create some old blocks
2020-05-15T18:53:39.608000Z TestFramework (INFO): Testing miner fund minerfund on bit 0.
2020-05-15T18:53:40.330000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 163, in main
    self.run_test()
  File "/work/test/functional/abc-miner-fund.py", line 82, in run_test
    run_test_for(0, 'minerfund', MINER_FUND_ADDR)
  File "/work/test/functional/abc-miner-fund.py", line 80, in run_test_for
    self.run_miner_fund_test(bit, name, address)
  File "/work/test/functional/abc-miner-fund.py", line 143, in run_miner_fund_test
    'since': 432,
  File "/work/test/functional/abc-miner-fund.py", line 40, in check_bip9_state
    assert_equal(miner_fund_info['bip9'], status)
  File "/work/test/functional/test_framework/util.py", line 50, in assert_equal
    for arg in (thing1, thing2) + args)))
AssertionError: not({'status': 'failed', 'start_time': 1573819200, 'timeout': 1589544000, 'since': 432} == {'status': 'locked_in', 'start_time': 1573819200, 'timeout': 1589544000, 'since': 432})
2020-05-15T18:53:40.381000Z TestFramework (INFO): Stopping nodes
2020-05-15T18:53:40.582000Z TestFramework (WARNING): Not cleaning up dir /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/abc-miner-fund_357
2020-05-15T18:53:40.582000Z TestFramework (ERROR): Test failed. Test logging available at /work/build/test/tmp/test_runner_₿₵_  _20200515_185228/abc-miner-fund_357/test_framework.log
2020-05-15T18:53:40.582000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/build/test/tmp/test_runner_₿₵_  _20200515_185228/abc-miner-fund_357' to consolidate all logs
[18:54:52]E:	 [Step 1/2] Failed tests detected
[18:54:51]W:	 [Step 1/2] Process exited with code 1
[18:54:53]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
Bitcoin ABC functional tests: abc-miner-fund.py

teamcity added a comment.May 15 2020, 18:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 15 2020, 18:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 15 2020, 18:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 15 2020, 18:56

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

deadalnix accepted this revision.May 15 2020, 18:57
teamcity added a comment.May 15 2020, 19:00

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 15 2020, 19:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10794: Diff 20118.May 15 2020, 19:05
Closed by commit rABCfca23c6355e1: Add checkpoints for phonon activation (authored by Fabien). · Explain WhyMay 15 2020, 19:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCfca23c6355e1: Add checkpoints for phonon activation.
Fabien added a commit: rSTAGINGfca23c6355e1: Add checkpoints for phonon activation.

Revision Contents
Changeset List

PathSize
src/
7 lines

Diff 20121

View Options

src/chainparams.cpp

Loading...