Page MenuHomePhabricator
Differential D6118

Lint everything
ClosedPublic
Actions

Authored by Fabien on May 18 2020, 16:19.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING5b88a18d4a50: Lint everything
rABC5b88a18d4a50: Lint everything
Summary

With updated python linting tools, one stylistic change and one real
issue found by the linter (the format() one).

Test Plan
ninja check-functionl

Should have no error:

arc lint --everything

Diff Detail

Event Timeline

Fabien created this revision.May 18 2020, 16:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 16:19
Fabien requested review of this revision.May 18 2020, 16:19
teamcity added a comment.May 18 2020, 16:25

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 16:26

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 16:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 16:33

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 16:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 18 2020, 16:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10826: Diff 20215.May 18 2020, 16:45
jasonbcox accepted this revision.May 18 2020, 16:53
This revision is now accepted and ready to land.May 18 2020, 16:53
Closed by commit rABC5b88a18d4a50: Lint everything (authored by Fabien). · Explain WhyMay 18 2020, 18:35
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5b88a18d4a50: Lint everything.
Fabien added a commit: rSTAGING5b88a18d4a50: Lint everything.May 18 2020, 18:40

Revision Contents
Changeset List

PathSize
contrib/
seeds/
5 lines
test/
functional/
test_framework/
2 lines

Diff 20215

View Options

contrib/seeds/generate-seeds.py

Loading...
View Options

test/functional/test_framework/script.py

Loading...