Page MenuHomePhabricator

Add support for inferring descriptors from scripts
ClosedPublic

Authored by deadalnix on May 18 2020, 20:58.

Details

Summary

This is a partial backport of Core PR14477 : https://github.com/bitcoin/bitcoin/pull/14477/commits/4d78bd93b5bdf886e743022e80f4edb8a982cf0d

I made InferPubkey static because it is only called from there.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.May 18 2020, 20:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 20:58
deadalnix requested review of this revision.May 18 2020, 20:58
teamcity edited the summary of this revision. (Show Details)May 18 2020, 20:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta requested changes to this revision.May 18 2020, 21:22
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/script/descriptor.cpp
833 ↗(On Diff #20233)

Wmissing-braces

This revision now requires changes to proceed.May 18 2020, 21:22
deadalnix added inline comments.May 18 2020, 21:24
src/script/descriptor.cpp
833 ↗(On Diff #20233)

I got owned by the formating :)

majcosta accepted this revision.May 18 2020, 21:29
This revision is now accepted and ready to land.May 18 2020, 21:29
This revision was landed with ongoing or failed builds.May 18 2020, 21:34
This revision was automatically updated to reflect the committed changes.