Page MenuHomePhabricator
Differential D6124

Add support for inferring descriptors from scripts
ClosedPublic
Actions

Authored by deadalnix on May 18 2020, 20:58.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGINGf011dbcfa172: Add support for inferring descriptors from scripts
rABCf011dbcfa172: Add support for inferring descriptors from scripts
Summary

This is a partial backport of Core PR14477 : https://github.com/bitcoin/bitcoin/pull/14477/commits/4d78bd93b5bdf886e743022e80f4edb8a982cf0d

I made InferPubkey static because it is only called from there.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.May 18 2020, 20:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 20:58
deadalnix requested review of this revision.May 18 2020, 20:58
teamcity edited the summary of this revision. (Show Details)May 18 2020, 20:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 18 2020, 20:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 20:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 18 2020, 20:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 21:02

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 21:03

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix added a child revision: D6126: Add tests for InferDescriptor and Descriptor::IsSolvable.May 18 2020, 21:10
teamcity added a comment.May 18 2020, 21:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10834: Diff 20233.May 18 2020, 21:12
majcosta requested changes to this revision.May 18 2020, 21:22
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/script/descriptor.cpp
833 ↗(On Diff #20233)

Wmissing-braces

This revision now requires changes to proceed.May 18 2020, 21:22
deadalnix added inline comments.May 18 2020, 21:24
src/script/descriptor.cpp
833 ↗(On Diff #20233)

I got owned by the formating :)

deadalnix updated this revision to Diff 20236.May 18 2020, 21:27

Braces

teamcity added a comment.May 18 2020, 21:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 18 2020, 21:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 18 2020, 21:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

majcosta accepted this revision.May 18 2020, 21:29
This revision is now accepted and ready to land.May 18 2020, 21:29
teamcity added a comment.May 18 2020, 21:29

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 18 2020, 21:31

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

This revision was landed with ongoing or failed builds.May 18 2020, 21:34
Closed by commit rABCf011dbcfa172: Add support for inferring descriptors from scripts (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCf011dbcfa172: Add support for inferring descriptors from scripts.
deadalnix added a commit: rSTAGINGf011dbcfa172: Add support for inferring descriptors from scripts.
teamcity added a comment.May 18 2020, 21:38

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10837: Diff 20236.May 18 2020, 21:38

Revision Contents
Changeset List

PathSize
src/
script/
20 lines
72 lines

Diff 20239

View Options

src/script/descriptor.h

Loading...
View Options

src/script/descriptor.cpp

Loading...