Add Descriptor::IsSolvable() to distinguish addr/raw from others
ClosedPublic
Actions

Authored by deadalnix on May 18 2020, 21:06.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7f84dccb831a: Add Descriptor::IsSolvable() to distinguish addr/raw from others
rABC7f84dccb831a: Add Descriptor::IsSolvable() to distinguish addr/raw from others

Summary

This is a partial backport of Core PR14477 : https://github.com/bitcoin/bitcoin/pull/14477/commits/225bf3e3b0a89a285da451cd589be148324039ab

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 18 2020, 21:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 18 2020, 21:06

deadalnix requested review of this revision.May 18 2020, 21:06

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

deadalnix added a child revision: D6126: Add tests for InferDescriptor and Descriptor::IsSolvable.May 18 2020, 21:10

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10835: Diff 20234.May 18 2020, 21:16

majcosta accepted this revision.May 18 2020, 21:26

This revision is now accepted and ready to land.May 18 2020, 21:26

Closed by commit rABC7f84dccb831a: Add Descriptor::IsSolvable() to distinguish addr/raw from others (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyMay 18 2020, 21:29

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7f84dccb831a: Add Descriptor::IsSolvable() to distinguish addr/raw from others.

deadalnix added a commit: rSTAGING7f84dccb831a: Add Descriptor::IsSolvable() to distinguish addr/raw from others.

Revision Contents
Changeset List

Path

Size

src/

script/

descriptor.h

7 lines

descriptor.cpp

7 lines

Diff 20237

View Options

src/script/descriptor.h