Page MenuHomePhabricator
Differential D6145

Reconsider checkpointed block at startup.
ClosedPublic
Actions

Authored by deadalnix on May 19 2020, 20:11.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rSTAGING40e2a445db94: Reconsider checkpointed block at startup.
rABC40e2a445db94: Reconsider checkpointed block at startup.
Summary

Because we know checkpoints are valid blocks, a checkpointed block marked as invalid is an obvious indication that something went wrogn in this datadir, such as running an incompatible node client.

In order to fix this, we make sure to reconsider heckpointed blocks at startup if necessary.

Test Plan

Run a node.

bitcoin-cli invalidateblock 00000000000000000033dfef1fc2d6a5d5520b078c55193a9bf498c5b27530f7

The node reorg a fe days of blockw away.

Restart the node and monitor the logs for.

Reconsidering checkpointed block 00000000000000000033dfef1fc2d6a5d5520b078c55193a9bf498c5b27530f7 ...

And verify that the node sync back to the tip of the chain.

Diff Detail

Event Timeline

deadalnix created this revision.May 19 2020, 20:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 20:11
deadalnix requested review of this revision.May 19 2020, 20:11
teamcity added a comment.May 19 2020, 20:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 20:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 20:11

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 20:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 20:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 20:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10867: Diff 20309.May 19 2020, 20:24
majcosta requested changes to this revision.May 19 2020, 20:28
majcosta added a subscriber: majcosta.

we should probably add a release-notes.md entry for this feature

src/init.cpp
1318 ↗(On Diff #20309)

couple typos

This revision now requires changes to proceed.May 19 2020, 20:28
deadalnix updated this revision to Diff 20313.May 19 2020, 23:06

Typos

majcosta accepted this revision.May 19 2020, 23:06
This revision is now accepted and ready to land.May 19 2020, 23:06
teamcity added a comment.May 19 2020, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 23:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 23:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

This revision was landed with ongoing or failed builds.May 19 2020, 23:15
Closed by commit rABC40e2a445db94: Reconsider checkpointed block at startup. (authored by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC40e2a445db94: Reconsider checkpointed block at startup..
teamcity added a comment.May 19 2020, 23:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10871: Diff 20313.May 19 2020, 23:19
deadalnix added a commit: rSTAGING40e2a445db94: Reconsider checkpointed block at startup..May 19 2020, 23:20
Mengerian added a subscriber: Mengerian.May 20 2020, 02:35

Although this is already landed, I had a 0.20.12 node synced to the non-upgraded chain, so I took the opportunity to test this Diff, and it behaved as expected.

I just started it up, and it synced to the correct chain with no user intervention.

Macro likestamp:

Revision Contents
Changeset List

PathSize
src/
21 lines

Diff 20313

View Options

src/init.cpp

Loading...