Page MenuHomePhabricator
Differential D6147

[backport#16728] move-only: move coins statistics utils out of RPC
ClosedPublic
Actions

Authored by majcosta on May 19 2020, 21:42.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING310fcb61841a: [backport#16728] move-only: move coins statistics utils out of RPC
rABC310fcb61841a: [backport#16728] move-only: move coins statistics utils out of RPC
Summary

These procedures will later be used in the ChainstateManager to compute
statistics (particularly a content hash) for UTXO sets coming in from
snapshots.

This is a backport of Core PR16728

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.May 19 2020, 21:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2020, 21:43
majcosta requested review of this revision.May 19 2020, 21:43
teamcity edited the summary of this revision. (Show Details)May 19 2020, 21:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.May 19 2020, 21:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 19 2020, 21:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 19 2020, 21:43

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 19 2020, 21:44

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 19 2020, 21:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 19 2020, 21:53

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10870: Diff 20312.May 19 2020, 21:53
Fabien requested changes to this revision.May 20 2020, 08:20
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/coinstats.h
10 ↗(On Diff #20312)

Why do you need chain.h ?
Also you're missing the BlockHash definition

This revision now requires changes to proceed.May 20 2020, 08:20
majcosta updated this revision to Diff 20353.May 20 2020, 13:10

replaced unnecessary headers

teamcity added a comment.May 20 2020, 13:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 13:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 13:14

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 13:15

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 13:19

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

teamcity added a comment.May 20 2020, 13:28

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10887: Diff 20353.May 20 2020, 13:28
deadalnix accepted this revision.May 20 2020, 17:33
majcosta updated this revision to Diff 20382.May 20 2020, 19:04

reincluded uint256.h to coinstats.h

teamcity added a comment.May 20 2020, 19:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

teamcity added a comment.May 20 2020, 19:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

teamcity added a comment.May 20 2020, 19:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

teamcity added a comment.May 20 2020, 19:08

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.May 20 2020, 19:13

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Fabien accepted this revision.May 20 2020, 19:20
Fabien added inline comments.
src/node/coinstats.h
22 ↗(On Diff #20353)

Keep #include <uint256.h> to avoid indirect inclusions

This revision is now accepted and ready to land.May 20 2020, 19:20
teamcity added a comment.May 20 2020, 19:22

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10907: Diff 20382.May 20 2020, 19:22
Closed by commit rABC310fcb61841a: [backport#16728] move-only: move coins statistics utils out of RPC (authored by James O'Beirne <james.obeirne@gmail.com>, committed by majcosta). · Explain WhyMay 20 2020, 19:27
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC310fcb61841a: [backport#16728] move-only: move coins statistics utils out of RPC.
majcosta added a commit: rSTAGING310fcb61841a: [backport#16728] move-only: move coins statistics utils out of RPC.May 20 2020, 19:30

Revision Contents
Changeset List

PathSize
src/
1 line
2 lines
node/
35 lines
79 lines
rpc/
76 lines

Diff 20385

View Options

src/CMakeLists.txt

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/node/coinstats.h

Loading...
View Options

src/node/coinstats.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...