Page MenuHomePhabricator

[backport#16728] move-only: move coins statistics utils out of RPC
ClosedPublic

Authored by majcosta on Tue, May 19, 21:42.

Details

Summary

These procedures will later be used in the ChainstateManager to compute
statistics (particularly a content hash) for UTXO sets coming in from
snapshots.


This is a backport of Core PR16728

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

majcosta created this revision.Tue, May 19, 21:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 19, 21:43
majcosta requested review of this revision.Tue, May 19, 21:43
teamcity edited the summary of this revision. (Show Details)Tue, May 19, 21:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Wed, May 20, 08:20
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/node/coinstats.h
10 ↗(On Diff #20312)

Why do you need chain.h ?
Also you're missing the BlockHash definition

This revision now requires changes to proceed.Wed, May 20, 08:20
majcosta updated this revision to Diff 20353.Wed, May 20, 13:10

replaced unnecessary headers

deadalnix accepted this revision.Wed, May 20, 17:33
majcosta updated this revision to Diff 20382.Wed, May 20, 19:04

reincluded uint256.h to coinstats.h

Fabien accepted this revision.Wed, May 20, 19:20
Fabien added inline comments.
src/node/coinstats.h
22 ↗(On Diff #20353)

Keep #include <uint256.h> to avoid indirect inclusions

This revision is now accepted and ready to land.Wed, May 20, 19:20