Paths

Table of Contentst

Differential D6164

[backport#16995] net: Fail instead of truncate command name in CMessageHeader
ClosedPublic
Actions

Authored by majcosta on May 20 2020, 14:41.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGc98781469a57: [backport#16995] net: Fail instead of truncate command name in CMessageHeader
rABCc98781469a57: [backport#16995] net: Fail instead of truncate command name in CMessageHeader

Summary

Replace the memset/strncpy dance in CMessageHeader::CMessageHeader
with explicit code that copies then name and asserts the length.

This removes a warning in g++ 9.1.1 and IMO makes the code more readable
by not relying on strncpy padding and silent truncation behavior.

https://github.com/bitcoin/bitcoin/pull/16995/commits/b837b334db5dd6232725fd2350928ff4fbd3feee

This is a partial backport of Core PR16995

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.May 20 2020, 14:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2020, 14:41

majcosta requested review of this revision.May 20 2020, 14:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-werror) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-without-wallet) passed.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B10891: Diff 20359.May 20 2020, 15:02

jasonbcox accepted this revision.May 20 2020, 17:30

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/protocol.h
53 ↗	(On Diff #20359)	Nit: newline after `/**`

This revision is now accepted and ready to land.May 20 2020, 17:30

Closed by commit rABCc98781469a57: [backport#16995] net: Fail instead of truncate command name in CMessageHeader (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyMay 20 2020, 18:19

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCc98781469a57: [backport#16995] net: Fail instead of truncate command name in CMessageHeader.

majcosta added a commit: rSTAGINGc98781469a57: [backport#16995] net: Fail instead of truncate command name in CMessageHeader.

Revision Contents
Changeset List

Path

Size

src/

protocol.h

7 lines

protocol.cpp

13 lines

Diff 20376

View Options

src/protocol.h